netdev - Re: [PATCH v2 net-next] tcp_metrics: fix wrong lockdep annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150316.163238.212681875092833561.davem@davemloft.net>
Date:	Mon, 16 Mar 2015 16:32:38 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	avagin@...allels.com, ebiederm@...ssion.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] tcp_metrics: fix wrong lockdep annotations

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 16 Mar 2015 07:14:34 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Changes in tcp_metric hash table are protected by tcp_metrics_lock
> only, not by genl_mutex
> 
> While we are at it use deref_locked() instead of rcu_dereference()
> in tcp_new() to avoid unnecessary barrier, as we hold tcp_metrics_lock
> as well.
>  
> Reported-by: Andrew Vagin <avagin@...allels.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Fixes: 098a697b497e ("tcp_metrics: Use a single hash table for all network namespaces.")

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html