netdev - Re: [PATCH] bogus MSG_PEEK test in rxrpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150315.222036.345825196151430543.davem@davemloft.net>
Date:	Sun, 15 Mar 2015 22:20:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	viro@...IV.linux.org.uk
Cc:	netdev@...r.kernel.org, dhowells@...hat.com
Subject: Re: [PATCH] bogus MSG_PEEK test in rxrpc_recvmsg()

From: Al Viro <viro@...IV.linux.org.uk>
Date: Sat, 14 Mar 2015 05:34:56 +0000

> [I would really like an ACK on that one from dhowells; it appears to be
> quite straightforward, but...]
> 
> MSG_PEEK isn't passed to ->recvmsg() via msg->msg_flags; as the matter of
> fact, neither the kernel users of rxrpc, nor the syscalls ever set that bit
> in there.  It gets passed via flags; in fact, another such check in the same
> function is done correctly - as flags & MSG_PEEK.
> 
> It had been that way (effectively disabled) for 8 years, though, so the patch
> needs beating up - that case had never been tested.  If it is correct, it's
> -stable fodder.
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Also applied and queued up for -stable, thanks Al.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html