netdev - Re: [linuxppc-release] [PATCH] net/fsl: modify xgmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55067EA9.7030303@Freescale.com>
Date:	Mon, 16 Mar 2015 01:56:41 -0500
From:	Emil Medve <Emilian.Medve@...escale.com>
To:	<shh.xie@...il.com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>
CC:	Shaohui Xie <Shaohui.Xie@...escale.com>
Subject: Re: [linuxppc-release] [PATCH] net/fsl: modify xgmac_mdio for little
 endian SoCs

Hello Shao-Hui,


On 03/16/2015 12:22 AM, shh.xie@...il.com wrote:
> From: Shaohui Xie <Shaohui.Xie@...escale.com>
> 
> MDIO controller on little endian Socs, e.g. ls2085a is similar to the
> controller on big endian Socs, but the MDIO access is little endian,
> we use I/O accessor function to handle endianness, so the driver can
> run on little endian Socs. A property "fsl,little-endian-mdio" is used
> in DTS to indicate the MDIO is little endian, if driver probes the
> property, driver will access MDIO in little endian.

Please use "{big,little}-endian" with "big-endian" being the default if
none is present. Please look at
Documentation/devicetree/bindings/regmap/regmap.txt and more then a
dozen FSL bindings already using this

> Also, fix a bug in xgmac_wait_until_done() which mdio_stat should be
> used instead of mdio_data when checking if busy bit is cleared.

Please split this into a separate patch

> Signed-off-by: Shaohui Xie <Shaohui.Xie@...escale.com>
> ---
>  drivers/net/ethernet/freescale/xgmac_mdio.c | 96 ++++++++++++++++++++---------
>  1 file changed, 68 insertions(+), 28 deletions(-)

Cheers,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html