netdev - RE: [linuxppc-release] [PATCH] net/fsl: modify xgmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY1PR03MB1486DA44A9C9A835A0FDAE92E2020@CY1PR03MB1486.namprd03.prod.outlook.com>
Date:	Mon, 16 Mar 2015 07:11:08 +0000
From:	Shaohui Xie <Shaohui.Xie@...escale.com>
To:	Emilian Medve <Emilian.Medve@...escale.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [linuxppc-release] [PATCH] net/fsl: modify xgmac_mdio for little
 endian SoCs

> On 03/16/2015 12:22 AM, shh.xie@...il.com wrote:
> > From: Shaohui Xie <Shaohui.Xie@...escale.com>
> >
> > MDIO controller on little endian Socs, e.g. ls2085a is similar to the
> > controller on big endian Socs, but the MDIO access is little endian,
> > we use I/O accessor function to handle endianness, so the driver can
> > run on little endian Socs. A property "fsl,little-endian-mdio" is used
> > in DTS to indicate the MDIO is little endian, if driver probes the
> > property, driver will access MDIO in little endian.
> 
> Please use "{big,little}-endian" with "big-endian" being the default if
> none is present. Please look at
> Documentation/devicetree/bindings/regmap/regmap.txt and more then a dozen
> FSL bindings already using this
[S.H] OK. I'll align driver with the Doc.

> 
> > Also, fix a bug in xgmac_wait_until_done() which mdio_stat should be
> > used instead of mdio_data when checking if busy bit is cleared.
> 
> Please split this into a separate patch
[S.H] OK. 

Thank you!
Shaohui
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html