netdev - Re: [PATCH net-next 0/6] inet: tcp listener refactoring, part 13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150318.220108.729418866702247151.davem@davemloft.net>
Date:	Wed, 18 Mar 2015 22:01:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	edumazet@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/6] inet: tcp listener refactoring, part 13

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 18 Mar 2015 14:05:32 -0700

> inet_hash functions are in a bad state : Too much IPv6/IPv4 copy/pasting.
> 
> Lets refactor a bit.
> 
> Idea is that we do not want to have an equivalent of inet_csk(sk)->icsk_af_ops
> for request socks in order to be able to use the right variant.
> 
> In this patch series, I started to let IPv6/IPv4 converge to common helpers.
> 
> Idea is to use ipv6_addr_set_v4mapped() even for AF_INET sockets, so that
> we can test
>        if (sk->sk_family == AF_INET6 &&
>            !ipv6_addr_v4mapped(&sk->sk_v6_daddr))
> to tell if we deal with an IPv6 socket, or IPv4 one, at least in slow paths.
> 
> Ideally, we could save 8 bytes per struct sock_common, if we
> alias skc_daddr & skc_rcv_saddr to skc_v6_daddr[3]/skc_v6_rcv_saddr[3].

Looks good, applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html