netdev - Re: [PATCH 2/3] ipv4,ipv6: kill ip_mc_{join,leave}_group and ipv6_sock_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150318.220532.2249494989719491502.davem@davemloft.net>
Date:	Wed, 18 Mar 2015 22:05:32 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	marcelo.leitner@...il.com
Cc:	netdev@...r.kernel.org, hannes@...essinduktion.org
Subject: Re: [PATCH 2/3] ipv4,ipv6: kill ip_mc_{join,leave}_group and
 ipv6_sock_mc_{join,drop}

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Wed, 18 Mar 2015 14:50:43 -0300

> in favor of their inner __ ones, which doesn't grab rtnl.
> 
> As these functions need to operate on a locked socket, we can't be
> grabbing rtnl by then. It's too late and doing so causes reversed
> locking.
> 
> So this patch:
> - move rtnl handling to callers instead while already fixing some
>   reversed locking situations, like on vxlan and ipvs code.
> - renames __ ones to not have the __ mark:
>   __ip_mc_{join,leave}_group -> ip_mc_{join,leave}_group
>   __ipv6_sock_mc_{join,drop} -> ipv6_sock_mc_{join,drop}
> 
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied to net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html