netdev - Re: [PATCH 3/3] vxlan: Move socket initialization to within rtnl scope

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150318.220538.841553909588344081.davem@davemloft.net>
Date:	Wed, 18 Mar 2015 22:05:38 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	marcelo.leitner@...il.com
Cc:	netdev@...r.kernel.org, hannes@...essinduktion.org
Subject: Re: [PATCH 3/3] vxlan: Move socket initialization to within rtnl
 scope

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Wed, 18 Mar 2015 14:50:44 -0300

> Currently, if a multicast join operation fail, the vxlan interface will
> be UP but not functional, without even a log message informing the user.
> 
> Now that we can grab socket lock after already having rntl, we don't
> need to defer socket creation and multicast operations. By not deferring
> we can do proper error reporting to the user through ip exit code.
> 
> This patch thus removes all deferred work that vxlan had and put it back
> inline. Now the socket will only be created, bound and join multicast
> group when one bring the interface up, and will undo all that as soon as
> one put the interface down.
> 
> As vxlan_sock_hold() is not used after this patch, it was removed too.
> 
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Applied to net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html