netdev - Re: [v1 PATCH 2/7] rhashtable: Allow hash/comparison functions to be inlined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150320120632.GJ28736@acer.localdomain>
Date:	Fri, 20 Mar 2015 12:06:32 +0000
From:	Patrick McHardy <kaber@...sh.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Thomas Graf <tgraf@...g.ch>,
	Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org
Subject: Re: [v1 PATCH 2/7] rhashtable: Allow hash/comparison functions to be
 inlined

On 20.03, Herbert Xu wrote:
> On Fri, Mar 20, 2015 at 11:20:42AM +0000, Patrick McHardy wrote:
> >
> > I haven't checked in detail yet whether this still satisfies what
> > we need in nftables, just a minor comment below:
> 
> AFAIK I have done nothing to break multiple keys as yet and
> the comparison function is still there, just embedded into the
> params structure.

Yep, seems fine on a quick skim, but it will take until tonight before
I can have a closer look.

> > > +struct rhashtable_compare_arg {
> > > +	struct rhashtable *ht;
> > > +	const void *key;
> > > +};
> > 
> > I found it a bit odd in the old interface that elementary data
> > such as the key for comparision is encapsulated into a structure
> > instead of passed as a function argument. Is there a reason
> > for not passing both as arguments so we can at least avoid the
> > encapsulation for the common case?
> 
> I don't have any objections against changing it but it could
> be done outside of this particular patch-set.

Absolutely. Just thought I mention it since you already touched all
relevant parts.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html