netdev - Re: [PATCH 4/5 net-next] rhashtable: Disable automatic shrinking by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150324.152924.921970094708836276.davem@davemloft.net>
Date:	Tue, 24 Mar 2015 15:29:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: [PATCH 4/5 net-next] rhashtable: Disable automatic shrinking
 by default

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 25 Mar 2015 05:55:45 +1100

> On Tue, Mar 24, 2015 at 02:18:19PM +0100, Thomas Graf wrote:
>> Using rhashtable_remove_fast() will no longer automatically
>> shrink the table. Users need to opt-in to shrinking by
>> explicitly using rhashtable_remove_and_shrink()
>> 
>> Signed-off-by: Thomas Graf <tgraf@...g.ch>
> 
> Note that this patch doesn't completely disable automatic shrinking
> since the worker thread can still trigger it.

Ok, but how do you feel about Thomas's series otherwise?

It looks fine to me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html