netdev - Re: [PATCH 1/5 net-next] rhashtable: Extend RCU read lock into rhashtable_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150324194044.GD19251@casper.infradead.org>
Date:	Tue, 24 Mar 2015 19:40:44 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org, herbert@...dor.apana.org.au
Subject: Re: [PATCH 1/5 net-next] rhashtable: Extend RCU read lock into
 rhashtable_insert_rehash()

On 03/24/15 at 02:18pm, Thomas Graf wrote:
> @@ -585,8 +585,8 @@ restart:
>  	if (unlikely(rht_grow_above_100(ht, tbl))) {
>  slow_path:
>  		spin_unlock_bh(lock);
> -		rcu_read_unlock();
>  		err = rhashtable_insert_rehash(ht);
> +		rcu_read_unlock();
>  		if (err)
>  			return err;

An alternative would be to start a new RCU section inside
rhashtable_insert_rehash(). This was the easier fix but I'm
fine either way.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html