[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55144329.3040501@list.ru>
Date: Thu, 26 Mar 2015 20:34:33 +0300
From: Stas Sergeev <stsp@...t.ru>
To: Florian Fainelli <f.fainelli@...il.com>
CC: netdev@...r.kernel.org,
Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Subject: Re: [PATCH 0/6] mvneta: SGMII-based in-band link status signaling
26.03.2015 20:29, Florian Fainelli пишет:
> On 26/03/15 10:23, Stas Sergeev wrote:
>> 26.03.2015 20:13, Florian Fainelli пишет:
>>> Hello,
>>>
>>> On 26/03/15 08:56, Stas Sergeev wrote:
>>>> Hello.
>>>>
>>>> The following patches are needed when mvneta is used
>>>> in SGMII mode without MDIO.
>>> Would you mind using scripts/get_maintainer.pl such that the relevant
>>> people who have touched this code in the past can be CC'd?
>>>
>>> Your patches are barely readable, let alone that you have provided
>>> little to explanation as to why you are making such invasive changes.
>> OK, will re-send tomorrow with more explanations and CCs.
>> Still not sure about "barely readable" though - I made them
>> through checkpatch.pl.
> Your commit messages are very scarce, you need to explain more what you
> are doing an why.
That's OK, will do, thanks.
You said that my patches and barely readable AND have
little explanation, so I thought you mean the code changes
itself are barely readable too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists