netdev - Re: [PATCH] of_net: factor out repetitive code from of_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150328132748.2DDA7C409FF@trevor.secretlab.ca>
Date:	Sat, 28 Mar 2015 13:27:48 +0000
From:	Grant Likely <grant.likely@...aro.org>
To:	David Miller <davem@...emloft.net>,
	sergei.shtylyov@...entembedded.com
Cc:	robh+dt@...nel.org, devicetree@...r.kernel.org,
	f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] of_net: factor out repetitive code
 from of_get_mac_address()

On Wed, 18 Mar 2015 15:29:33 -0400 (EDT)
, David Miller <davem@...emloft.net>
 wrote:
> From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Date: Wed, 18 Mar 2015 22:25:46 +0300
> 
> > of_get_mac_address() basically does the same  thing thrice, every  time with  a
> > different  property  name,  so it makes sense to factor out the repetitive code
> > into separate function. While at it, we can start using ETH_ALEN instead of the
> > bare number and drop unnecessary parens around the property length check.
> > 
> > The resulting ARM object file is 100 bytes less in size than before the patch.
> > 
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> > 
> > ---
> > The patch is against Grant Likely's 'linux.git' repo's 'devicetree/next' branch.
> 
> Acked-by: David S. Miller <davem@...emloft.net>

Applied for v4.1, thanks.

g.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html