netdev - Re: [PATCH] of_net: factor out repetitive code from of_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5516E245.30605@cogentembedded.com>
Date:	Sat, 28 Mar 2015 20:17:57 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Grant Likely <grant.likely@...aro.org>, robh+dt@...nel.org,
	devicetree@...r.kernel.org, f.fainelli@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] of_net: factor out repetitive code from of_get_mac_address()

Hello.

On 03/28/2015 04:34 PM, Grant Likely wrote:

>> of_get_mac_address() basically does the same  thing thrice, every  time with  a
>> different  property  name,  so it makes sense to factor out the repetitive code
>> into separate function. While at it, we can start using ETH_ALEN instead of the
>> bare number and drop unnecessary parens around the property length check.

>> The resulting ARM object file is 100 bytes less in size than before the patch.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

>> ---
>> The patch is against Grant Likely's 'linux.git' repo's 'devicetree/next' branch.

> Thanks for looking at this, I've merged it.

> Since you're already playing with this, could you also write a unittest
> of of_get_mac_addr()? (drivers/of/unittest.c & drivers/of/unittest-data)

    Unfortunately, I'm constantly low on time. Even this patch was done on 
weekend.

> g.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html