netdev - Re: [PATCH net] openvswitch: Return vport module ref before destruction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+pC2V3XV5wvoT90_0-sscHzK=0NkVpQNjKfPQn-z2Kufg@mail.gmail.com>
Date:	Mon, 30 Mar 2015 11:19:07 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>
Subject: Re: [PATCH net] openvswitch: Return vport module ref before destruction

On Mon, Mar 30, 2015 at 4:57 AM, Thomas Graf <tgraf@...g.ch> wrote:
> Return module reference before invoking the respective vport
> ->destroy() function. This is needed as ovs_vport_del() is not
> invoked inside an RCU read side critical section so the kfree
> can occur immediately before returning to ovs_vport_del().
>
> Returning the module reference before ->destroy() is safe because
> the module unregistration is blocked on ovs_lock which we hold
> while destroying the datapath.
>
> Fixes: 62b9c8d0372d ("ovs: Turn vports with dependencies into separate modules")
> Reported-by: Pravin Shelar <pshelar@...ira.com>
> Signed-off-by: Thomas Graf <tgraf@...g.ch>

looks good.
Acked-by: Pravin B Shelar <pshelar@...ira.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html