netdev - Re: [PATCH net] openvswitch: Return vport module ref before destruction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150331.160031.2170838715047996686.davem@davemloft.net>
Date:	Tue, 31 Mar 2015 16:00:31 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	netdev@...r.kernel.org, dev@...nvswitch.org, pshelar@...ira.com
Subject: Re: [PATCH net] openvswitch: Return vport module ref before
 destruction

From: Thomas Graf <tgraf@...g.ch>
Date: Mon, 30 Mar 2015 13:57:41 +0200

> Return module reference before invoking the respective vport
> ->destroy() function. This is needed as ovs_vport_del() is not
> invoked inside an RCU read side critical section so the kfree
> can occur immediately before returning to ovs_vport_del().
> 
> Returning the module reference before ->destroy() is safe because
> the module unregistration is blocked on ovs_lock which we hold
> while destroying the datapath.
> 
> Fixes: 62b9c8d0372d ("ovs: Turn vports with dependencies into separate modules")
> Reported-by: Pravin Shelar <pshelar@...ira.com>
> Signed-off-by: Thomas Graf <tgraf@...g.ch>
> ---
> @Dave: Please also queue for 3.19.x stable series

Applied and queued up for -stable, thanks Thomas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html