netdev - Re: [PATCH net-next 13/18] switchdev: remove unused NETIF_F_HW_SWITCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bDBdjvZ0VAzX19ZP3h4i9GpNnXyO6RqgKMNnHx0em_x9A@mail.gmail.com>
Date:	Mon, 30 Mar 2015 14:20:55 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	roopa <roopa@...ulusnetworks.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	Jiří Pírko <jiri@...nulli.us>,
	Guenter Roeck <linux@...ck-us.net>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 13/18] switchdev: remove unused NETIF_F_HW_SWITCH_OFFLOAD

On Mon, Mar 30, 2015 at 6:38 AM, roopa <roopa@...ulusnetworks.com> wrote:
> On 3/30/15, 1:40 AM, sfeldma@...il.com wrote:
>>
>> From: Scott Feldman <sfeldma@...il.com>
>>
>> Flag is no longer needed so remove it.  Using the attr get/set recurse
>> algo
>> obsoletes the flag.  Setting the flag on bond/team interface, even when
>> the
>> consitient member ports didn't have flag set was confusing.
>>
>> Signed-off-by: Scott Feldman <sfeldma@...il.com>
>
>
> The flag was there to avoid the recursive lowerdev walk where possible.
> bond will have the flag if any one slave can have it. You don't walk the
> bond if it does not have the flag.

Ok, I see.  I'll remove this patch from set.  Should I put the
NETIF_F_HW_SWITCH_OFFLOAD check in the get/set attr wrappers?

> Also, this allows the user to disable the feature from userspace if required
> and move everything to software.
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html