netdev - Re: [PATCH net-next 11/18] switchdev: remove old netdev_switch_port_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bA4t-5P58jeK1NVAzM1fdk72o9UJRD8w+ByxKAtbp7b8A@mail.gmail.com>
Date:	Mon, 30 Mar 2015 14:27:48 -0700
From:	Scott Feldman <sfeldma@...il.com>
To:	"Arad, Ronen" <ronen.arad@...el.com>
Cc:	roopa <roopa@...ulusnetworks.com>, Netdev <netdev@...r.kernel.org>,
	Jirí Pírko <jiri@...nulli.us>,
	Guenter Roeck <linux@...ck-us.net>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 11/18] switchdev: remove old netdev_switch_port_bridge_setlink

On Mon, Mar 30, 2015 at 1:46 PM, Arad, Ronen <ronen.arad@...el.com> wrote:
>
>
>>-----Original Message-----
>>From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On
>>Behalf Of Scott Feldman
>>Sent: Monday, March 30, 2015 1:20 PM
>>To: roopa
>>Cc: Netdev; Jiří Pírko; Guenter Roeck; Florian Fainelli
>>Subject: Re: [PATCH net-next 11/18] switchdev: remove old
>>netdev_switch_port_bridge_setlink
>>
>>On Mon, Mar 30, 2015 at 6:23 AM, roopa <roopa@...ulusnetworks.com> wrote:
>>> On 3/30/15, 1:40 AM, sfeldma@...il.com wrote:
>>>>
>>>> From: Scott Feldman <sfeldma@...il.com>
>>>>
>>>> New attr-based bridge_setlink can recurse lower devs and recover on err,
>>>> so
>>>> remove old wrapper.  Also, restore br_setlink back to original and don't
>>>> call
>>>> into SELF port driver.  rtnetlink.c:bridge_setlink already does a call
>>>> into
>>>> port driver for SELF.
>>>>
>>>> Signed-off-by: Scott Feldman <sfeldma@...il.com>
>>>
>>> removing this now requires every vlan add to be a two step process, why ?
>>
>>No, that's not true.  You want to use
>>ndo_vlan_rx_add_vid/ndo_vlan_rx_kill_vid in your port driver, and then
>>using either vlan driver standalone or the bridge driver vlan support
>>will work.
>>
>>Try it.  Implement ndo_vlan_rx_add_vid in your port driver and verify
>>you get called to add VLAN to port with either:
>>
>>    bridge vlan add dev swp1 vid 10
>>
>>    -or-
>>
>>    vconfig add swp1 10
>>
>>Same for deleting a VLAN, either of these two commands call into the
>>port driver ndo_vlan_rx_kill_vid:
>>
>>    bridge vlan del dev swp1 vid 10
>>
>>    -or-
>>
>>    vconfig rem swp1 10
>>
>>
>>> bridge vlan add dev swp1 vid 10
>>> bridge vlan add dev swp1 vid 10 self
>>
>>Not necessary.  The first command is sufficient if using
>>ndo_vlan_rx_add_vid.
>
> This is not sufficient for VLAN filtering. Ndo_vlan_rx_add_vid does not
> provide the vinfo flags PVID and UNTAGGED. Therefore it is not
> an adequate replacement for propagating setlink/dellink messages to the
> swithport driver or an alternative via swdev_attr.

Glad you bring that point up.  I think these can get cast as port
attrs and set using swdev_attr.  This is something swdev attr should
open up is allowing more settings to be pushed down to port driver.
I'll look into this one and include it with v2.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html