netdev - Re: [PATCH net-next] net: smc91x: Remove an unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150331173800.GJ17728@pengutronix.de>
Date:	Tue, 31 Mar 2015 19:38:01 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	David Miller <davem@...emloft.net>
Cc:	festevam@...il.com, netdev@...r.kernel.org,
	fabio.estevam@...escale.com
Subject: Re: [PATCH net-next] net: smc91x: Remove an unused variable

On Tue, Mar 31, 2015 at 10:53:28AM -0400, David Miller wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Date: Mon, 30 Mar 2015 19:20:57 +0200
> 
> > On Mon, Mar 30, 2015 at 01:43:38PM -0300, Fabio Estevam wrote:
> >> From: Fabio Estevam <fabio.estevam@...escale.com>
> >> 
> >> Commit cb6e0b3690f48dff ("net: smc91x: make use of 4th parameter to devm_gpiod_get_index")
> >> caused the following build warning:
> >> 
> >> drivers/net/ethernet/smsc/smc91x.c:2208:6: warning: unused variable 'res' [-Wunused-variable]
> >> 
> >> Remove the unused 'res' variable.
> >> 
> >> Reported-by: Olof's autobuilder <build@...om.net>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> > I wonder why I didn't notice this because the 0day build robot tested my
> > tree and didn't report this warning. Probably that means this driver
> > wasn't tested.
> 
> This driver can't be enabled on x86/x86-64 so the build testing it will
> get is going to be extremely limited.
The build bot also builds other archs, at least arm and powerpc, but I
think there are more.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html