netdev - Re: [PATCH net-next v2] net: bcmgenet: enable MoCA link state change detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150401.134037.1631948165977093044.davem@davemloft.net>
Date:	Wed, 01 Apr 2015 13:40:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pgynther@...gle.com
Cc:	netdev@...r.kernel.org, f.fainelli@...il.com, jaedon.shin@...il.com
Subject: Re: [PATCH net-next v2] net: bcmgenet: enable MoCA link state
 change detection

From: Petri Gynther <pgynther@...gle.com>
Date: Wed,  1 Apr 2015 00:40:00 -0700 (PDT)

> Currently, MoCA fixed PHYs are always in link-up state, regardless of
> whether the link is actually up or not.
> 
> Add code to properly detect MoCA link state changes and to reflect the
> new state in MoCA fixed PHY. Only GENET V3 and V4 MACs are capable of
> detecting MoCA link state changes.
> 
> The code works as follows:
> 1. GENET MAC detects MoCA link state change and issues UMAC_IRQ_LINK_UP
>    or UMAC_IRQ_LINK_DOWN interrupt.
> 2. Link up/down interrupt is processed in bcmgenet_irq_task(), which
>    calls phy_mac_interrupt().
> 3. phy_mac_interrupt() updates the fixed PHY phydev->link and kicks
>    the PHY state machine.
> 4. PHY state machine proceeds to read the fixed PHY link status
>    register.
> 5. When the fixed PHY link status register is being read, the new
>    function bcmgenet_fixed_phy_link_update() gets called. It copies
>    the fixed PHY phydev->link value to the fixed PHY status->link.
> 6. PHY state machine receives the new link state of the fixed PHY.
> 7. MoCA fixed PHY link state now correctly reflects the real MoCA
>    hardware link state.
> 
> Signed-off-by: Petri Gynther <pgynther@...gle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html