netdev - Re: [PATCH RFCv2 3/4] batman-adv: Forward IGMP/MLD reports to selected querier (only)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150401.134431.1653220163353310062.davem@davemloft.net>
Date:	Wed, 01 Apr 2015 13:44:31 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	linus.luessing@...3.blue
Cc:	b.a.t.m.a.n@...ts.open-mesh.org, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org
Subject: Re: [PATCH RFCv2 3/4] batman-adv: Forward IGMP/MLD reports to
 selected querier (only)

From: Linus Lüssing <linus.luessing@...3.blue>
Date: Wed,  1 Apr 2015 10:04:38 +0200

> With this patch IGMP or MLD reports are only forwarded to the selected
> IGMP/MLD querier as RFC4541 suggests. This is necessary to avoid
> multicast packet loss in bridged scenarios later:
> 
> An IGMPv2/MLDv1 querier does not actively join the multicast group the
> reports are sent to. Because of this, this leads to snooping
> bridges/switches not being able to learn of multicast listeners in the
> mesh and wrongly shutting down ports for multicast traffic to the mesh.

There is no way this is going to work.

First of all, you have no proper Kconfig dependencies upon IPV6, yet
you are calling these newly exported ipv6 multicast interfaces
unconditionally.

Even once you resolve that, you are going to run into problems in
situations where BATMAN_ADV=y and IPV6=m, for example.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html