netdev - Re: [PATCH 3/3] ethtool: Add support to get expansion ROM version in ethtool getdrvinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1428203123.11260.161.camel@decadent.org.uk>
Date:	Sun, 05 Apr 2015 04:05:23 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Hariprasad S <hariprasad@...lsio.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, leedom@...lsio.com,
	anish@...lsio.com, nirranjan@...lsio.com, kumaras@...lsio.com
Subject: Re: [PATCH 3/3] ethtool: Add support to get expansion ROM version
 in ethtool getdrvinfo

On Wed, 2015-03-25 at 14:11 +0530, Hariprasad S wrote:
> On Wed, Feb 04, 2015 at 18:19:36 +0530, Hariprasad Shenai wrote:
> > Rename the reserved1 field of ethtool_drvinfo to erom_version, and use it to get
> > the expansion ROM version of the adapter.
> > 
> > Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>
> > ---
> >  ethtool-copy.h |    3 ++-
> >  ethtool.c      |    2 ++
> >  2 files changed, 4 insertions(+), 1 deletions(-)
> > 
> > diff --git a/ethtool-copy.h b/ethtool-copy.h
> > index 61b78fc..e2df0e5 100644
> > --- a/ethtool-copy.h
> > +++ b/ethtool-copy.h
> > @@ -148,6 +148,7 @@ static __inline__ __u32 ethtool_cmd_speed(const struct ethtool_cmd *ep)
> >   *	not be an empty string.
> >   * @version: Driver version string; may be an empty string
> >   * @fw_version: Firmware version string; may be an empty string
> > + * @erom_version: Expansion ROM version string; may be an empty string
> >   * @bus_info: Device bus address.  This should match the dev_name()
> >   *	string for the underlying bus device, if there is one.  May be
> >   *	an empty string.
> > @@ -176,7 +177,7 @@ struct ethtool_drvinfo {
> >  	char	version[32];
> >  	char	fw_version[ETHTOOL_FWVERS_LEN];
> >  	char	bus_info[ETHTOOL_BUSINFO_LEN];
> > -	char	reserved1[32];
> > +	char	erom_version[32];
> >  	char	reserved2[12];
> >  	__u32	n_priv_flags;
> >  	__u32	n_stats;
> > diff --git a/ethtool.c b/ethtool.c
> > index bf583f3..b7d2206 100644
> > --- a/ethtool.c
> > +++ b/ethtool.c
> > @@ -701,6 +701,7 @@ static int dump_drvinfo(struct ethtool_drvinfo *info)
> >  		"driver: %.*s\n"
> >  		"version: %.*s\n"
> >  		"firmware-version: %.*s\n"
> > +		"expansion-rom-version: %.*s\n"
> >  		"bus-info: %.*s\n"
> >  		"supports-statistics: %s\n"
> >  		"supports-test: %s\n"
> > @@ -710,6 +711,7 @@ static int dump_drvinfo(struct ethtool_drvinfo *info)
> >  		(int)sizeof(info->driver), info->driver,
> >  		(int)sizeof(info->version), info->version,
> >  		(int)sizeof(info->fw_version), info->fw_version,
> > +		(int)sizeof(info->erom_version), info->erom_version,
> >  		(int)sizeof(info->bus_info), info->bus_info,
> >  		info->n_stats ? "yes" : "no",
> >  		info->testinfo_len ? "yes" : "no",
> > -- 
> > 1.7.1
> > 
> 
> 
> Hi Ben,
> 
> Can you pull this one to the ethtool repo?

Applied, thanks.

Ben.

-- 
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)