netdev - Re: 3.19+: (and quite probably earlier) VIA Rhine hanging under high network load, yet again: redux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150405.000134.2167854544742576874.davem@davemloft.net>
Date:	Sun, 05 Apr 2015 00:01:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	nix@...eri.org.uk, rl@...lgate.ch, gurligebis@...too.org,
	netdev@...r.kernel.org
Subject: Re: 3.19+: (and quite probably earlier) VIA Rhine hanging under
 high network load, yet again: redux

From: Francois Romieu <romieu@...zoreil.com>
Date: Sat, 4 Apr 2015 23:05:18 +0200

> Nix <nix@...eri.org.uk> :
> [...]
> 
> This driver leaves holes in its receive ring under memory pressure.
> It may not help.
> 
> You can try the gross patch below against v3.19. It compiles. I have to go.

Indeed, converting this driver to just drop packets when skb
allocation fails on receive, and just reusing the original skb and
placing it back into the RX ring, is the way to go.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html