netdev - Re: [PATCH RFT net-next 0/4] via-rhine receive buffers rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150407193110.GB24631@electric-eye.fr.zoreil.com>
Date:	Tue, 7 Apr 2015 21:31:10 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Nix <nix@...eri.org.uk>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	rl@...lgate.ch, Bjarke Istrup Pedersen <gurligebis@...too.org>
Subject: Re: [PATCH RFT net-next 0/4] via-rhine receive buffers rework

Nix <nix@...eri.org.uk> :
[...]
> No crashes in several hours of running: looks good!

Mildly. :o/

You may never notice if you don't resume and the reset work queue doesn't
run but patch #4 lacks the bits below.

(rx_head_desc should go away)

diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c
index a54a9f4..7f31c3a 100644
--- a/drivers/net/ethernet/via/via-rhine.c
+++ b/drivers/net/ethernet/via/via-rhine.c
@@ -1244,6 +1244,7 @@ static void rhine_reset_rbufs(struct rhine_private *rp)
 	int i;
 
 	rp->cur_rx = 0;
+	rp->rx_head_desc = rp->rx_ring;
 
 	for (i = 0; i < RX_RING_SIZE; i++)
 		rp->rx_ring[i].rx_status = cpu_to_le32(DescOwn);
@@ -1268,7 +1269,6 @@ static int alloc_rbufs(struct net_device *dev)
 	int rc, i;
 
 	rp->rx_buf_sz = (dev->mtu <= 1500 ? PKT_BUF_SZ : dev->mtu + 32);
-	rp->rx_head_desc = &rp->rx_ring[0];
 	next = rp->rx_ring_dma;
 
 	/* Init the ring entries */

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html