netdev - Re: [PATCH] sh_eth: move inline functions to the header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150407.153337.1789757717574323514.davem@davemloft.net>
Date:	Tue, 07 Apr 2015 15:33:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	netdev@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH] sh_eth: move inline functions to the header file

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Tue, 07 Apr 2015 22:26:23 +0300

> Hello.
> 
> On 04/07/2015 10:22 PM, David Miller wrote:
> 
>>> The explicitly inline functions belong to the header files, so move
>>> cpu_to_edmac() and edmac_to_cpu() into the driver header.
> 
>>> While at it, make these functions return 'u32' instead of '__u32'.
> 
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 
>> Then... ummm... remove the inline keyword?
> 
>> If it's not used anywhere else, that's the thing to do.
> 
>    Results in more code, as I noted in the patch posting that you skipped
>    when replying. At least with gcc 4.7.

That's a compiler bug.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html