netdev - Re: [PATCH net-next 1/4] via-rhine: commit receive buffer address before descriptor status update.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150407210248.GC24631@electric-eye.fr.zoreil.com>
Date:	Tue, 7 Apr 2015 23:02:48 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, nix@...eri.org.uk, rl@...lgate.ch,
	gurligebis@...too.org,
	Alexander Duyck <alexander.h.duyck@...hat.com>
Subject: Re: [PATCH net-next 1/4] via-rhine: commit receive buffer address
 before descriptor status update.

David Miller <davem@...emloft.net> :
> From: Francois Romieu <romieu@...zoreil.com>
[...]
> > @@ -2063,6 +2063,7 @@ static int rhine_rx(struct net_device *dev, int limit)
> >  				break;
> >  			}
> >  			rp->rx_ring[entry].addr = cpu_to_le32(rp->rx_skbuff_dma[entry]);
> > +			wmb();
> 
> dma_wmb() perhaps?  I think this is exactly the situation that interface was
> added for.

I need the buffer address to be written in the receive descriptor before
the descriptor status is. The cpu does W1, W2 and the nic mustn't see W2, W1.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html