netdev - Re: [PATCH v3 net-next 2/2] tc: add 'needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1428593798.25985.256.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 09 Apr 2015 08:36:38 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	Alexei Starovoitov <ast@...mgrid.com>,
	David Miller <davem@...emloft.net>, tgraf@...g.ch,
	jiri@...nulli.us, jhs@...atatu.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 2/2] tc: add 'needs_l2' flag to ingress qdisc

On Thu, 2015-04-09 at 17:15 +0200, Daniel Borkmann wrote:
> On 04/09/2015 07:20 AM, Alexei Starovoitov wrote:
> ...
> > we cannot change the meaning of ld_abs, since for dgram sockets
> > offset is actually not pointing to L2.
> > af_packet is doing:
> >   if (sk->sk_type != SOCK_DGRAM)
> >        skb_push(skb, skb->data - skb_mac_header(skb));
> >   res = run_filter(skb, sk, snaplen);
> > so not everything assumes L2.
> 
> It would be not just that e.g. sock_queue_rcv_skb() users
> have differing offset assumptions as well when they call
> from their protocols into sk_filter().

It seems that passing an extra parameter
could help those users, and would remove the requirement
of skb_clone() from dev_queue_xmit_nit()

skb_clone() would only be done after run_filter()

Maybe we'll finally have a fast packet capture, instead of simply
focusing on the filter part, which is tiny.

Lets take this discussion as the incentive to finally get this done
right.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html