netdev - Re: [PATCH net-next v4 07/24] switchdev: add port vlan obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150413132703.GD2090@nanopsycho.lan>
Date:	Mon, 13 Apr 2015 15:27:03 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	linux@...ck-us.net, f.fainelli@...il.com,
	sridhar.samudrala@...el.com, ronen.arad@...el.com, andrew@...n.ch
Subject: Re: [PATCH net-next v4 07/24] switchdev: add port vlan obj

Mon, Apr 13, 2015 at 03:16:25PM CEST, jiri@...nulli.us wrote:
>Mon, Apr 13, 2015 at 08:17:01AM CEST, sfeldma@...il.com wrote:
>>From: Scott Feldman <sfeldma@...il.com>
>>
>>VLAN obj has flags (PVID and untagged) as well as start and end vid ranges.
>>The swdev driver can optimize programing the device using the ranges.
>>
>>Signed-off-by: Scott Feldman <sfeldma@...il.com>
>>---
>> include/net/switchdev.h |    8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>>diff --git a/include/net/switchdev.h b/include/net/switchdev.h
>>index f5f7733..d3cc8eb 100644
>>--- a/include/net/switchdev.h
>>+++ b/include/net/switchdev.h
>>@@ -45,12 +45,20 @@ struct fib_info;
>> 
>> enum swdev_obj_id {
>> 	SWDEV_OBJ_UNDEFINED,
>>+	SWDEV_OBJ_PORT_VLAN,
>> };
>> 
>> struct swdev_obj {
>> 	enum swdev_obj_id id;
>> 	enum swdev_trans trans;
>> 	u32 flags;
>>+	union {
>>+		struct swdev_obj_vlan {			/* PORT_VLAN */
>>+			u16 flags;
>>+			u16 vid_start;
>>+			u16 vid_end;
>>+		} vlan;
>>+	};
>
>Same here. Please squash this with the next patch.

I mean 09. The infrastructure should be first, usage (by driver) after
that.

>
>
>> };
>> 
>> /**
>>-- 
>>1.7.10.4
>>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html