netdev - Re: [PATCH net-next v4 07/24] switchdev: add port vlan obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552C0190.8080606@gmail.com>
Date:	Mon, 13 Apr 2015 10:49:04 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	sfeldma@...il.com, netdev@...r.kernel.org
CC:	jiri@...nulli.us, roopa@...ulusnetworks.com, linux@...ck-us.net,
	sridhar.samudrala@...el.com, ronen.arad@...el.com, andrew@...n.ch
Subject: Re: [PATCH net-next v4 07/24] switchdev: add port vlan obj

On 12/04/15 23:17, sfeldma@...il.com wrote:
> From: Scott Feldman <sfeldma@...il.com>
> 
> VLAN obj has flags (PVID and untagged) as well as start and end vid ranges.
> The swdev driver can optimize programing the device using the ranges.
> 
> Signed-off-by: Scott Feldman <sfeldma@...il.com>
> ---
>  include/net/switchdev.h |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index f5f7733..d3cc8eb 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -45,12 +45,20 @@ struct fib_info;
>  
>  enum swdev_obj_id {
>  	SWDEV_OBJ_UNDEFINED,
> +	SWDEV_OBJ_PORT_VLAN,
>  };
>  
>  struct swdev_obj {
>  	enum swdev_obj_id id;
>  	enum swdev_trans trans;
>  	u32 flags;
> +	union {
> +		struct swdev_obj_vlan {			/* PORT_VLAN */
> +			u16 flags;

Should not we enforce some sort of definition of how we plan on using
the "flags" member here?, if not, we might just as well remove it from
this patch set until we actually use it?
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html