netdev - RE: [PATCH 15/17] switch kernel_sendmsg() and kernel_recvmsg() to iov_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CB1DE00@AcuExch.aculab.com>
Date:	Tue, 14 Apr 2015 16:36:36 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Al Viro' <viro@...IV.linux.org.uk>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 15/17] switch kernel_sendmsg() and kernel_recvmsg() to
 iov_iter_kvec()

From: Al Viro 
> Sent: 14 April 2015 17:34
> On Tue, Apr 14, 2015 at 04:21:02PM +0000, David Laight wrote:
> 
> > Massive NAK.
> > This breaks any code that is using msg_control to set SCTP parameters
> > when sending data.
> 
> 	Huh?  ->sendmsg() expects ->msg_control already in kernel space;
> it's ->recvmsg() that plays silly buggers with userland pointers there.

I read your commit message as implying that you hadn't found any
users of kernel_sendmsg() that used msg_control.
Not that the data was always read from kernel space.

	David

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html