netdev - Re: [PATCH 16/17] get rid of the size argument of sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150414164427.GA889@ZenIV.linux.org.uk>
Date:	Tue, 14 Apr 2015 17:44:28 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 16/17] get rid of the size argument of sock_sendmsg()

On Tue, Apr 14, 2015 at 05:35:34PM +0100, Al Viro wrote:
> On Tue, Apr 14, 2015 at 04:25:24PM +0000, David Laight wrote:
> > From: Al Viro
> > > Sent: 11 April 2015 22:18
> > > it's equal to iov_iter_count(&msg->msg_iter) in all cases
> > 
> > I don't know whether this is guaranteed for iov[] that come from
> > userspace.
> >
> > In any case iov_iter_count() is non-trivial and you don't
> > really want to call it when unnecessary.
> 
> Really?
> 
> static inline size_t iov_iter_count(struct iov_iter *i)
> {
>         return i->count;
> }

Incidentally, have you even looked at the patch?  sock_write_iter():
-       res = sock_sendmsg(sock, &msg, iov_iter_count(from));
+       res = sock_sendmsg(sock, &msg);
sys_sendto():
-       err = sock_sendmsg(sock, &msg, iov_iter_count(&msg.msg_iter));
+       err = sock_sendmsg(sock, &msg);
__sys_sendmsg():
-       total_len = iov_iter_count(&msg_sys->msg_iter);
-       err = sock_sendmsg(sock, msg_sys, total_len);
+       err = sock_sendmsg(sock, msg_sys);
kernel_sendmsg():
        iov_iter_kvec(&msg->msg_iter, WRITE | ITER_KVEC, vec, num, size);
-       return sock_sendmsg(sock, msg, size);
+       return sock_sendmsg(sock, msg);
... and iov_iter_kvec() sets ->count to its last argument, so after the
first line we'll have iov_iter_count(&msg->msg_iter) == size.
svc_sendto():
-               if (sock_sendmsg(sock, &msg, 0) < 0)
+               if (sock_sendmsg(sock, &msg) < 0)
and msg->msg_iter is all-zeroes there, including ->msg_iter.count.

In cases when iov comes from userland we used to have iov_iter_count(...)
passed there; no need to even look its definition up.  It's an equivalent
transformation, no matter what...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html