netdev - Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Apr 2015 18:46:22 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Erez Shitrit <erezsh@....mellanox.co.il>,
	Honggang Li <honli@...hat.com>
CC:	Roland Dreier <roland@...nel.org>, sean.hefty@...el.com,
	hal.rosenstock@...il.com, kaber@...sh.net, davem@...emloft.net,
	Alex Estrin <alex.estrin@...el.com>,
	Doug Ledford <dledford@...hat.com>, edumazet@...gle.com,
	Erez Shitrit <erezsh@...lanox.com>, maheshb@...gle.com,
	jbenc@...hat.com, ebiederm@...ssion.com,
	elfring@...rs.sourceforge.net, f.fainelli@...il.com,
	linux@...ck-us.net, andrew@...n.ch, sfeldma@...il.com,
	alexander.h.duyck@...el.com,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer
 dereference in ipoib_get_iflink

Le 14/04/2015 18:30, Erez Shitrit a écrit :
> On Tue, Apr 14, 2015 at 6:20 PM, Honggang Li <honli@...hat.com> wrote:
[snip]
> This will make parent interface to return 0 instead of its own ifindex.
> I would suggest write something like that:
>
> +       /* parent interface */
> +       if (!test_bit(IPOIB_FLAG_SUBINTERFACE, &priv->flags))
> +               return dev->ifindex;
> +
> +       /* child/vlan interface */
> +       if (!priv->parent)
> +               return -1;
'return 0' here.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html