netdev - Re: [PATCH] ip_forward: Drop frames with attached skb->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150414.125045.1736152567665368862.davem@davemloft.net>
Date:	Tue, 14 Apr 2015 12:50:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sebastian.poehn@...il.com
Cc:	stephen@...workplumber.org, netdev@...r.kernel.org, fw@...len.de,
	eric.dumazet@...il.com
Subject: Re: [PATCH] ip_forward: Drop frames with attached skb->sk

From: Sebastian Poehn <sebastian.poehn@...il.com>
Date: Tue, 14 Apr 2015 08:18:40 +0200

> On Mon, 2015-04-13 at 23:07 -0700, Stephen Hemminger wrote:
>> On Tue, 14 Apr 2015 07:52:04 +0200
>> Sebastian Poehn <sebastian.poehn@...il.com> wrote:
>> 
>> >  
>> > +	/* this should happen neither */
>> > +	if (unlikely(skb->sk))
>> > +		goto drop;
>> > +
>> 
>> With gcc, all goto's are already treated as unlikely().
> 
> Thanks for that recommendation. But before I re-cook: What about Clang
> and ICC?

I think even if this is the case with gcc, it's good documentation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html