netdev - Re: [PATCH resend] Renesas Ethernet AVB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <552D472A.6080309@cogentembedded.com>
Date:	Tue, 14 Apr 2015 19:58:18 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Richard Cochran <richardcochran@...il.com>
CC:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, devicetree@...r.kernel.org,
	galak@...eaurora.org, netdev@...r.kernel.org,
	linux-sh@...r.kernel.org,
	Mitsuhiro Kimura <mitsuhiro.kimura.kc@...esas.com>,
	masaru.nagai.vx@...esas.com
Subject: Re: [PATCH resend] Renesas Ethernet AVB driver

Hello.

On 04/14/2015 07:30 PM, Richard Cochran wrote:

>>> It is surely avoidable.  The driver knows (or should know) whether or
>>> not the hardware has been configured or not.

>>     So you only want to avoid the register read here?

> No, that is not what I mean.  The two callers are gettime and adjtime.
> Can't you make sure the hardware is ready before you register the

    I tried to explain to you that I can't. We enter the device configuration 
mode (from the operation mode) when e.g. the *Ethernet* device is closed.

> clock in the first place?  If not, what is purpose of returning EBUSY?

    I'm not sure (remember, I'm not the primary author), perhaps this is to 
prevent bad time values when the AVB-DMAC in not operational... Nagai-san, 
could you explain this please?

> Thanks,
> Richard

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html