netdev - Re: [v2] act_mirred: Fix bogus header when redirecting from VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150417.132902.1510959002713450218.davem@davemloft.net>
Date:	Fri, 17 Apr 2015 13:29:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	alexei.starovoitov@...il.com, netdev@...r.kernel.org,
	hadi@...erus.ca
Subject: Re: [v2] act_mirred: Fix bogus header when redirecting from VLAN

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 17 Apr 2015 13:32:09 +0800

> On Thu, Apr 16, 2015 at 07:40:30PM -0700, Alexei Starovoitov wrote:
>> On Fri, Apr 17, 2015 at 10:15:01AM +0800, Herbert Xu wrote:
>> > > seems the cleaner fix will be to push skb->mac_len instead?
>> > 
>> > No skb->mac_len is the same as skb2->dev->hard_header_len.
>> 
>> hmm. please help me understand the problem then.
>> In the commit log you mentioned that your vlan dev and ifb
>> have unequal hard header length. I think that can only happen if
>> your master dev used to create vlan, didn't have vlan offload,
>> so vlandev->hhl = 18 and ifb->hhl = 14. Then when tagged packet
>> arrives on master device we call skb_vlan_untag() and
>> skb->mac_len becomes 14, then vlan_do_receive() will do
> 
> You are right.  I should've just used mac_len.
> 
> ---8<---
> When you redirect a VLAN device to any device, you end up with
> crap in af_packet on the xmit path because hard_header_len is
> not equal to skb->mac_len.  So the redirected packet contains
> four extra bytes at the start which then gets interpreted as
> part of the MAC address.
> 
> This patch fixes this by only pushing skb->mac_len.  We also
> need to fix ifb because it tries to undo the pushing done by
> act_mirred.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html