netdev - Re: [PATCH] net: remove unused 'dev' argument from netif_needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150417.132909.1859863736464111217.davem@davemloft.net>
Date:	Fri, 17 Apr 2015 13:29:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	netdev@...r.kernel.org, therbert@...gle.com, jesse@...ira.com,
	johannes.berg@...el.com
Subject: Re: [PATCH] net: remove unused 'dev' argument from
 netif_needs_gso()

From: Johannes Berg <johannes@...solutions.net>
Date: Fri, 17 Apr 2015 15:45:04 +0200

> From: Johannes Berg <johannes.berg@...el.com>
> 
> In commit 04ffcb255f22 ("net: Add ndo_gso_check") Tom originally
> added the 'dev' argument to be able to call ndo_gso_check().
> 
> Then later, when generalizing this in commit 5f35227ea34b
> ("net: Generalize ndo_gso_check to ndo_features_check")
> Jesse removed the call to ndo_gso_check() in netif_needs_gso()
> by calling the new ndo_features_check() in a different place.
> This made the 'dev' argument unused.
> 
> Remove the unused argument and go back to the code as before.
> 
> Cc: Tom Herbert <therbert@...gle.com>
> Cc: Jesse Gross <jesse@...ira.com>
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html