netdev - Re: [PATCHv3] pppoe: Lacks DST MAC address check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150420.152728.2303510459953341238.davem@davemloft.net>
Date:	Mon, 20 Apr 2015 15:27:28 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	joakim.tjernlund@...nsmode.se
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCHv3] pppoe: Lacks DST MAC address check

From: Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
Date: Mon, 20 Apr 2015 21:07:48 +0200

> From: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
> 
> A pppoe session is identified by its session ID and MAC address.
> Currently pppoe does not check if the received pkg has the correct
> MAC address. This is a problem when the eth I/F is in promisc mode
> as then any DST MAC address is accepted.
> 
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@...nsmode.se>
> ---
>  drivers/net/ppp/pppoe.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> v2 - The MAC address check should encompass all pppoe pkgs,
>      not only the relay type.
> 
> v3 - Add signoff

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html