netdev - Re: [RFC PATCH 06/10] ipv6: Avoid deleting RTF_CACHE route from ip6_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150420.153718.918911597668800943.davem@davemloft.net>
Date:	Mon, 20 Apr 2015 15:37:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kafai@...com
Cc:	netdev@...r.kernel.org, hannes@...essinduktion.org,
	kernel-team@...com
Subject: Re: [RFC PATCH 06/10] ipv6: Avoid deleting RTF_CACHE route from
 ip6_route_del()

From: Martin KaFai Lau <kafai@...com>
Date: Mon, 20 Apr 2015 12:33:05 -0700

> On Mon, Apr 20, 2015 at 02:23:05PM -0400, David Miller wrote:
>> From: Martin KaFai Lau <kafai@...com>
>> Date: Fri, 10 Apr 2015 18:54:09 -0700
>> 
>> > Before patch 'Allow pmtu update on /128 via gateway route',
>> > RTF_CACHE route was not created for DST_HOST.  It also requires changes on both
>> > delete code path and rt6_select() code patch.
>> > 
>> > This patch fixes the delete code path to avoid deleting the RTF_CACHE
>> > route by 'ip -6 r del...'
>> > 
>> > Signed-off-by: Martin KaFai Lau <kafai@...com>
>> > Reviewed-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
>> 
>> If a cached route was created in response to say a PMTU event, and
>> it's a clone/copy/cow of the route we are being asked to delete,
>> it absolutely should be removed.
>> 
>> In fact this is a critically important aspect of removing routes
>> from the table.
> When a non-clone routes are removed, its clones are removed together by
> fib6_prune_clones() in fib6_del().
> 
> Hence, 'ip -6 r del' will remove a route and its clones.
> 'ip -6 r flush table cache will only remove RTF_CACHE routes.
> 
> I will fix up the commit message.

Ok, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html