lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150421.173540.1253961571051792975.davem@davemloft.net>
Date:	Tue, 21 Apr 2015 17:35:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	michael@...rulasolutions.com
Cc:	peppe.cavallaro@...com, festevam@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH V2] net: stmmac: use msleep instead of udelay for gpio
 reset

From: Michael Trimarchi <michael@...rulasolutions.com>
Date: Tue, 21 Apr 2015 13:16:13 +0200

> -			udelay(data->delays[0]);
 ...
> +			msleep(max(1U, data->delays[0] / 1000));

That looks very ugly with that max() expression in there.

Please find some clean way to get rid of it if you want to
make this conversion.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ