netdev - Re: [PATCH V2] net: stmmac: use msleep instead of udelay for gpio reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150421231347.GA3392@panicking>
Date:	Wed, 22 Apr 2015 01:13:47 +0200
From:	Michael Trimarchi <michael@...rulasolutions.com>
To:	David Miller <davem@...emloft.net>
Cc:	peppe.cavallaro@...com, festevam@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH V2] net: stmmac: use msleep instead of udelay for gpio
 reset

Hi

On Tue, Apr 21, 2015 at 05:35:40PM -0400, David Miller wrote:
> From: Michael Trimarchi <michael@...rulasolutions.com>
> Date: Tue, 21 Apr 2015 13:16:13 +0200
> 
> > -			udelay(data->delays[0]);
>  ...
> > +			msleep(max(1U, data->delays[0] / 1000));
> 
> That looks very ugly with that max() expression in there.
>

Is fine for you a DIV_ROUND_UP?

> Please find some clean way to get rid of it if you want to
> make this conversion.
>

Agree, I will repost it

Michael

> Thanks.

-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html