netdev - Re: [PATCH net] tcp: fix possible deadlock in tcp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Apr 2015 14:50:14 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	johunt@...mai.com, netdev@...r.kernel.org, edumazet@...gle.com,
	gthelen@...gle.com, rientjes@...gle.com
Subject: Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 22 Apr 2015 11:39:27 -0700

> Note that in the unlikely case skb can not be allocated,
> if an already transmitted packet is in the write queue, we also can OR
> the FIN flag on it, and rely on normal rtx to deliver this FIN later.
> 
> I'll cook a patch when net-next reopens.

Hmmm, we already check for something like this at the beginning of
tcp_send_fin(), I know because I added that piece of code 15+ years
ago :-)

Or are you suggesting something slightly different?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html