netdev - Re: [PATCH net] tcp: fix possible deadlock in tcp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1429727967.18561.129.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 22 Apr 2015 11:39:27 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	johunt@...mai.com, netdev@...r.kernel.org, edumazet@...gle.com,
	gthelen@...gle.com, rientjes@...gle.com
Subject: Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

On Wed, 2015-04-22 at 14:15 -0400, David Miller wrote:

> Wrt. longer term solutions, I would even be OK at this point aborting
> the connection altogether if the skb allocation fails period.  Not
> just if TIF_MEMDIE is set.  That endless loop has been nothing but
> trouble.

Agreed.

Note that in the unlikely case skb can not be allocated,
if an already transmitted packet is in the write queue, we also can OR
the FIN flag on it, and rely on normal rtx to deliver this FIN later.

I'll cook a patch when net-next reopens.

Thanks David.




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html