netdev - Re: [PATCH net 0/3] netlink: fix wrong use of the flag NLM_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150429.150015.854202938628093066.davem@davemloft.net>
Date:	Wed, 29 Apr 2015 15:00:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	netdev@...r.kernel.org, dmitry.tarnyaginuug.ch@...nd.com
Subject: Re: [PATCH net 0/3] netlink: fix wrong use of the flag NLM_F_MULTI

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Tue, 28 Apr 2015 18:33:47 +0200

> The first three patches fix a wrong use of this flag.
> 
> Because it's not the first time that this kind of bug happens, it could be
> good to find something to help people.
> 
> The only idea that I have is in the last patch. It's just an example, if
> people agrees on it, I will update all users and submit it formally.
> Any better idea is welcomed.

I've applied this series.

The only thing with patch #4 is that we have to make sure everyone
initializes all fields.  It would be nice if there were a way to
sort-of enforce that.

Even just having a static inline initializer helper func might be
enough, like I added for nf_hook_info.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html