netdev - Re: [PATCH net 2/3] bridge/nl: remove wrong use of NLM_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1430398906.2669.111.camel@jtkirshe-mobl>
Date:	Thu, 30 Apr 2015 06:01:46 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	dmitry.tarnyaginuug.ch@...nd.com,
	John Fastabend <john.r.fastabend@...el.com>,
	Sathya Perla <sathya.perla@...lex.com>,
	Subbu Seetharaman <subbu.seetharaman@...lex.com>,
	Ajit Khaparde <ajit.khaparde@...lex.com>,
	intel-wired-lan@...ts.osuosl.org, Jiri Pirko <jiri@...nulli.us>,
	Scott Feldman <sfeldma@...il.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net 2/3] bridge/nl: remove wrong use of NLM_F_MULTI

On Tue, 2015-04-28 at 18:33 +0200, Nicolas Dichtel wrote:
> NLM_F_MULTI must be used only when a NLMSG_DONE message is sent. In
> fact,
> it is sent only at the end of a dump.
> 
> Libraries like libnl will wait forever for NLMSG_DONE.
> 
> Fixes: e5a55a898720 ("net: create generic bridge ops")
> Fixes: 815cccbf10b2 ("ixgbe: add setlink, getlink support to ixgbe and
> ixgbevf")
> CC: John Fastabend <john.r.fastabend@...el.com>
> CC: Sathya Perla <sathya.perla@...lex.com>
> CC: Subbu Seetharaman <subbu.seetharaman@...lex.com>
> CC: Ajit Khaparde <ajit.khaparde@...lex.com>
> CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> CC: intel-wired-lan@...ts.osuosl.org
> CC: Jiri Pirko <jiri@...nulli.us>
> CC: Scott Feldman <sfeldma@...il.com>
> CC: Stephen Hemminger <stephen@...workplumber.org>
> CC: bridge@...ts.linux-foundation.org
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

For the i40e and ixgbe driver changes

> ---
>  drivers/net/ethernet/emulex/benet/be_main.c   |  5 +++--
>  drivers/net/ethernet/intel/i40e/i40e_main.c   |  7 ++++---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  4 ++--
>  drivers/net/ethernet/rocker/rocker.c          |  5 +++--
>  include/linux/netdevice.h                     |  6 ++++--
>  include/linux/rtnetlink.h                     |  2 +-
>  net/bridge/br_netlink.c                       |  4 ++--
>  net/bridge/br_private.h                       |  2 +-
>  net/core/rtnetlink.c                          | 12 +++++++-----
>  9 files changed, 27 insertions(+), 20 deletions(-)



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)