netdev - Re: [PATCH] net/rds: fix unaligned memory access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55425609.8060107@oracle.com>
Date:	Thu, 30 Apr 2015 10:19:21 -0600
From:	David Ahern <david.ahern@...cle.com>
To:	David Miller <davem@...emloft.net>
CC:	rds-devel@....oracle.com, netdev@...r.kernel.org,
	shamir.rabinovitch@...cle.com
Subject: Re: [PATCH] net/rds: fix unaligned memory access

On 4/30/15 9:44 AM, David Miller wrote:
> From: David Ahern <david.ahern@...cle.com>
> Date: Thu, 30 Apr 2015 10:27:53 -0400
>
>> @@ -183,8 +183,17 @@ void rds_ib_cm_connect_complete(struct rds_connection *conn, struct rdma_cm_even
>>
>>   	/* If the peer gave us the last packet it saw, process this as if
>>   	 * we had received a regular ACK. */
>> -	if (dp && dp->dp_ack_seq)
>> -		rds_send_drop_acked(conn, be64_to_cpu(dp->dp_ack_seq), NULL);
>> +	if (dp) {
>> +		/* dp structure start is not guaranteed to be 8 bytes aligned
>> +		 * so on SPARC we get trap for nu-aligned access. we solve
>> +		 * this by using the macros for unaligned memory access
>> +		 */
>
> "nu-aligned" is misspelled, and Mentioning sparc specifically is completely
> inappropriate because this is not a sparc specific problem.
>

oops meant to take that out. Will fix and resubmit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html