netdev - Re: [PATCH net-next 3/5] ipv6: Stop /128 route from disappearing after pmtu update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 3 May 2015 17:29:38 -0700
From:	Martin KaFai Lau <kafai@...com>
To:	Hajime Tazaki <tazaki@....wide.ad.jp>
CC:	<netdev@...r.kernel.org>, <hannes@...essinduktion.org>,
	<steffen.klassert@...unet.com>, <davem@...emloft.net>,
	<yangyingliang@...wei.com>, <shengyong1@...wei.com>,
	<Kernel-team@...com>
Subject: Re: [PATCH net-next 3/5] ipv6: Stop /128 route from disappearing
 after pmtu update

Hi Hajime,

On Sun, May 03, 2015 at 12:01:09PM -0700, Martin KaFai Lau wrote:
> Thanks for the details and confirming the last patch.  I think I may
> know what could be wrong.  I am going to confirm it first by trying
> to reproduce it.
I tried the sit and also the gre6 tunnel.  I cannot make it break as
the way you have observed.  The ping can still go through.  I am probably
missing something.

However, I did uncover a problem in this patch and posted a fix to
netdev.  I have also attached here.  Can you give it a try?

If there is still no luck, do you have a chance to
reproduce it with a simple setup by iproute2 commands?
Can you specify which POINTTOPOINT device and sim device you are using?
Are they in or out of kernel-tree driver?

Thanks,
--Martin

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 3522711..106dbe5 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -920,7 +920,7 @@ redo_rt6_select:

 	if (!(rt->rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY)))
 		nrt = rt6_alloc_cow(rt, &fl6->daddr, &fl6->saddr);
-	else if (!(rt->dst.flags & DST_HOST) || !(rt->dst.flags & RTF_LOCAL))
+	else if (!(rt->dst.flags & DST_HOST) || !(rt->rt6i_flags & RTF_LOCAL))
 		nrt = rt6_alloc_clone(rt, &fl6->daddr);
 	else
 		goto out2;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html