netdev - Re: [RFC PATCH net-next 0/8] Convert some skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 May 2015 16:38:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-next 0/8] Convert some skb_<foo> functions to
 void

On Tue, 2015-05-05 at 19:20 -0400, David Miller wrote:
> From: Joe Perches <joe@...ches.com> Date: Mon, 04 May 2015 13:32:30 -0700
> > On Mon, 2015-05-04 at 13:05 -0700, Joe Perches wrote:
> >> unsigned char * return values are sometimes awkward to work with.
> >> Changing the return to void * is sometimes clearer.
> >> 
> >> The only uses of the return type is to do sets like
> >>     *skb_puts(skb, 1) = char;
> >>     
> >> Adding another function specifically for that purpose allows the return
> >> type to become void.
> > 
> > Obviously, this shouldn't be applied as-is.
> > 
> > It spans too many subsystems and can be done
> > more incrementally.
> > 
> > Also, there are some missing conversions so
> > this won't compile properly (sorry 'bout that)
> 
> I have no fundamental issues with this series once you fix up those
> issues.

OK, good.

Another thing that's fairly common is an skb_put followed by
a memcpy or memset.

Adding a couple of functions for those like:

void *skb_put_memcpy(struct sk_buff *skb, void *from, size_t size);
void *skb_put_memset(struct sk_buff *skb, int c, size_t size);

would reduce code size and improve performance a little.

Are you OK with that too?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html