netdev - Re: [RFC PATCH net-next 0/8] Convert some skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1430914779.14545.28.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 06 May 2015 05:19:39 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-next 0/8] Convert some skb_<foo> functions to
 void

On Tue, 2015-05-05 at 16:38 -0700, Joe Perches wrote:

> 
> Another thing that's fairly common is an skb_put followed by
> a memcpy or memset.
> 
> Adding a couple of functions for those like:
> 
> void *skb_put_memcpy(struct sk_buff *skb, void *from, size_t size);
> void *skb_put_memset(struct sk_buff *skb, int c, size_t size);
> 
> would reduce code size and improve performance a little.
> 
> Are you OK with that too?

Could we stop the API inflation and code churn, please.

You have little idea of the hassle this means for people like us doing
backports and code maintenance, preventing us from doing useful work,
like fixing real bugs and issues.

You know, even something very simple as the 'extern' removal in include
files had consumed days of work for us because of merge conflicts, and
reviewer time.

( commit 5c9f30236f53f3fbee170e2452dfa0e5dce4727b for example)

We understand the code as is, with regular memcpy() and memset()

These functions are fine. They were fine 20 years ago, nothing changed.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html