netdev - Re: [RFC PATCH net-next 0/8] Convert some skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1430928887.9365.90.camel@perches.com>
Date:	Wed, 06 May 2015 09:14:47 -0700
From:	Joe Perches <joe@...ches.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-next 0/8] Convert some skb_<foo> functions to
 void

On Wed, 2015-05-06 at 05:19 -0700, Eric Dumazet wrote:
> On Tue, 2015-05-05 at 16:38 -0700, Joe Perches wrote:
> > Another thing that's fairly common is an skb_put followed by
> > a memcpy or memset.
> > Adding a couple of functions for those like:
> > void *skb_put_memcpy(struct sk_buff *skb, void *from, size_t size);
> > void *skb_put_memset(struct sk_buff *skb, int c, size_t size);
> > would reduce code size and improve performance a little.

[]

> We understand the code as is, with regular memcpy() and memset()
> These functions are fine. They were fine 20 years ago, nothing changed.

Prefer speed and size improvements over stasis.

alloc+memset works, zalloc exists.

Using these functions would reduce a non-modular defconfig
x86-64 net/built-in.o by a couple kb.

Probably double that for a kernel.

These functions would be used in the packet processing path
for wireless too.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html