netdev - Re: [PATCH net-next 6/7] packet: rollover huge flows before small flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTScaDNf2OfjbSN8aSvQz+e_USDh7EuNZDLrhGhfe1rDXrQ@mail.gmail.com>
Date:	Wed, 6 May 2015 16:19:36 -0400
From:	Willem de Bruijn <willemb@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Network Development <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-next 6/7] packet: rollover huge flows before small flows

On Wed, May 6, 2015 at 4:16 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Wed, 2015-05-06 at 16:06 -0400, Willem de Bruijn wrote:
>
>> Do you suggest running lockless, similar to the rfs table?
>> I can reduce history length to make hist_idx fit in the same
>> cacheline.
>
> I suggest not using hit_idx at all, and no lock either.
>
> for (i = 0; i < ROLLOVER_HLEN; i++)
>       if (po->rollover->history[i] == rxhash)
>               count++;
>
> po->rollover->history[prandom_u32() % ROLLOVER_HLEN] = rxhash;

Thanks, I'll do that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html