netdev - Re: [PATCH net-next v5 12/21] switchdev: remove old switchdev_port_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150507153340.GA2121@nanopsycho>
Date:	Thu, 7 May 2015 17:33:40 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	linux@...ck-us.net, f.fainelli@...il.com,
	sridhar.samudrala@...el.com, ronen.arad@...el.com, andrew@...n.ch,
	simon.horman@...ronome.com
Subject: Re: [PATCH net-next v5 12/21] switchdev: remove old
 switchdev_port_bridge_setlink

Tue, May 05, 2015 at 07:34:48PM CEST, sfeldma@...il.com wrote:
>From: Scott Feldman <sfeldma@...il.com>
>
>New attr-based bridge_setlink can recurse lower devs and recover on err, so
>remove old wrapper.  Also, restore br_setlink back to original and don't
>call into SELF port driver.  rtnetlink.c:bridge_setlink already does a call
>into port driver for SELF.
>

Although the patch description does not say so, this patch really
removes "ndo_dflt_switchdev_port_bridge_setlink".

....


> 	}
> 
>-	if (p && !(flags & BRIDGE_FLAGS_SELF)) {
>-		/* set bridge attributes in hardware if supported
>-		 */
>-		ret_offload = switchdev_port_bridge_setlink(dev, nlh, flags);
>-		if (ret_offload && ret_offload != -EOPNOTSUPP)
>-			br_warn(p->br, "error setting attrs on port %u(%s)\n",
>-				(unsigned int)p->port_no, p->dev->name);
>-	}
>-

Also, I think that this hunk should be as a separate patch as I really
don't see direct relation with the rest of the patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html